Skip to content

Fix new Rust 1.83 clippy lints #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarijnS95 merged 2 commits into from
Dec 27, 2024
Merged

Fix new Rust 1.83 clippy lints #198

MarijnS95 merged 2 commits into from
Dec 27, 2024

Conversation

@MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented Dec 22, 2024

Clippy is once again detecting more noise and simplifications in codebases 🎉

@MarijnS95 MarijnS95 mentioned this pull request Dec 27, 2024
Open
@MarijnS95
Copy link
Member Author

MarijnS95 commented Dec 27, 2024

Besides fixing plain errors, we should also look into warnings like what's fixed on the cc side with rust-lang/cc-rs#1256. cc-rs is going to pass --target with a version making our hardcoded version-min "obsolete":

xbuild/xbuild/src/cargo/mod.rs

Lines 362 to 364 in ffe3e34

self.add_cflag(&format!("-miphoneos-version-min={}", minimum_version));
self.add_link_arg("--target=arm64-apple-ios");
self.add_link_arg(&format!("-miphoneos-version-min={}", minimum_version));

Resulting in warnings like:

warning: [email protected]: clang: warning: overriding '-miphoneos-version-min=14.0' option with '--target=arm64-apple-ios17.5' [-Woverriding-t-option]

@MarijnS95 MarijnS95 merged commit 58eb125 into master Dec 27, 2024
34 checks passed
@MarijnS95 MarijnS95 deleted the clippy branch December 27, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarijnS95